refactor: updated lock file version check to use new workflow #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullahwaheed
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 169 169
Lines 3450 3450
Branches 898 898
=======================================
Hits 3187 3187
Misses 243 243
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
Hi @Mashal-m, Just to confirm. Are you still working on this PR? We are planning the board cleanup. Should I close this PR? |
|
Hi @Mashal-m any updates on this PR? |
|
It is ready to review and merge.
|
awais-ansari
approved these changes
Nov 8, 2023
awais-ansari
force-pushed
the
mashal-m/update_lockfile
branch
from
ad65a2d
to
e79ad9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed
lockfileversion-check-v3tolockfile-checkin lockfile version file.Ticket
Prototype a way to review NPM lockfiles in PRs
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist